Skip to content

Conversation

@kvaps
Copy link
Member

@kvaps kvaps commented Jun 27, 2025

This change references to upstream issue clastix/kamaji#856

It's better to use ordinary service instead accessing etcd via multiple endpoints from kubernetes-api due to DNS resloving issue, which might happen when one replica have no IP address assigned.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 27, 2025

Walkthrough

The etcdcluster manifest was updated to simplify the DataStore endpoints from multiple pod-specific DNS entries to a single service DNS entry. Additionally, the DNS names in the etcd-server and etcd-peer Certificate specifications were expanded to include three more service-related DNS names.

Changes

File(s) Change Summary
examples/manifests/etcdcluster-kamaji.yaml Simplified DataStore endpoints to a single service DNS; added three new DNS names to Certificate specs.

Poem

In the cluster where data flows free,
Endpoints unite, as simple as can be.
Certificates grow with new DNS delight,
Etcd's connections now shining bright.
With every hop and every name,
Kamaji’s cluster won a simpler game!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 856fede and dd4c9ac.

📒 Files selected for processing (1)
  • examples/manifests/etcdcluster-kamaji.yaml (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: pre-commit
  • GitHub Check: test-e2e on k8s penultimate version
  • GitHub Check: test-e2e on k8s latest version
  • GitHub Check: test on k8s latest version
  • GitHub Check: test on k8s penultimate version
  • GitHub Check: test-e2e on k8s previous version
  • GitHub Check: test on k8s previous version
🔇 Additional comments (3)
examples/manifests/etcdcluster-kamaji.yaml (3)

140-143: Service DNS SANs are a welcome addition

Adding the three service-level names ensures clients using the new service endpoint pass TLS verification.
No issues spotted.


178-181: Mirror change for peer certificate looks good

The same SANs on the peer cert keep intra-cluster traffic valid when connecting via the service.


23-25: ```shell
#!/bin/bash

Locate and display the first 50 lines of the example manifest to verify its kind and context

file=$(fd etcdcluster-kamaji.yaml | head -n1)
echo "Found file: $file"
head -n 50 "$file"


</details>

</blockquote></details>

</details>
<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKNwSPbABsvkCiQBHbGlcSHFcLzpIACI0CXx4elgSNFpIxEQAGmj7bAFmdRp6OUhsREpIAGsJNG5kNGRbSAxHAQqAJgBOAEZMngp8bnxy5FwAd3xIZm0sBlhMUkQNSAAxeApEXD71dB98MeRmfH8w+DZIADNjsOTIElwGegYvMpo+AntcZ1Dsbj7eaSOFReeQfM68fBST4qeBedTya7+OEwuG4eS0bAUeAYIgoDDqeBoOEAL2o8HwGGWAGVRBTaNtQnEErRkGVsbjmN5xNxIncMLQhtjcMgrnwANJoaZCeB9MYIOZTNDyRDguEXUG3JgYchiclYa5ai7wIiYskU/r4BjSJYwW5NVBxbReYEeUV+EgSeAkMboUKwXC4OocAD0waI6lgeQ0TGYwbQZHgAA8wOTg/dHmBBsoCBRg9xvF5g11uhojPpjOAoGR6PgLjgCMQyNmojG2BhOP1+MJROIpDJ5EwlFRVOotDpyyYoHBUA6sGg8IRSOQqEUFKx2FwqD6HE4XJASoPlCPNNpdGBDBXTAYSInJTzpMHpviLiFEGmHrRnq9KGBKpK0NKGiyJKXgcAY0QQQYFiQAAggAko2y7UFEO7THutaMPMOLSG4tzVoK7bIHCmx4jcHgACLUGgVI5h4iDcKIkBjA09iqvARpRBcAzMDc/geNitCSIk2BEjwiiQORAByVJ8rgWLSExEZiRQwphJMaCsTivLlBQnpWhJ0myXuYwRvgeDoMpmiwbQgniBSRIgn0uC3FJMkYJKCnOFQsjINiZF3B+YA6VIfCYPQ6a0GADEVAAwpQ4hGgwyH2AxDDIGMlAeDeND8lEJSpIJOK8SQHjkD67DyYgXDRBF0R9DVH4aH+UrwEFPk0MwGiIBIDB1eg/IxBFTX/tKbWbCQnXdQw0YvONFAaF4lpEtEyzuOUmELAp2DPhqWX8gRoT+C+/gYPpYV3Im3Dnc5FGGe5bDIEwIV5btMAADIyVaKnsfASU0EsRjmJYMFeG8ZoYKMkw3ZASjPM44PIBhN5DCpUTXPmAhwgwskEjhBiSRSJClhB0Rluel5VgNGHzg2S7Nk8LBth2W65Lu8gHooR5qCe47k5Oa4FLgAD6iSIEL/iet6dBC5s3xnhe/M2QALAwnRoAwAAcADsAi0AIACsFxoFrFz6yQADMnRq90WtK0rAAM3TtKonQkAAbDbWu0Br8sUwL6giyy4sel6GW0EL1by0AA=== -->

<!-- internal state end -->
<!-- tips_start -->

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

<details>
<summary>❤️ Share</summary>

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

</details>

<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=aenix-io/etcd-operator&utm_content=291):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Explain this complex logic.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai explain this code block.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and explain its main purpose.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

### Support

Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.

### CodeRabbit Configuration File (`.coderabbit.yaml`)

- You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository.
- Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json`

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->

kvaps added a commit to cozystack/cozystack that referenced this pull request Jul 2, 2025
…1128)

ref to #1127,
clastix/kamaji#856 and
aenix-io/etcd-operator#291

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
  * Updated etcd chart to version 2.9.0.
* **Improvements**
* Simplified etcd endpoint configuration to use a single static
endpoint.
* Expanded TLS certificate DNS names to include additional service
addresses.
  * Streamlined resource configuration for etcd deployment.
* **Chores**
  * Updated version mapping for etcd package.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants